Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error messages #721

Merged
merged 6 commits into from
Dec 20, 2024
Merged

Better error messages #721

merged 6 commits into from
Dec 20, 2024

Conversation

UE4SS
Copy link
Collaborator

@UE4SS UE4SS commented Dec 19, 2024

Description

This PR makes various improvements to error messages.

Screenshots

Before
image

After
image

Copy link
Contributor

MSVC-Game__Debug__Win64 Download Logs
Build Details
Name Information
PR Commit 7867897
Merge Commit 40d1262
Size 46.68 MB
Last Updated Dec 19, 24, 8:53:20 PM UTC
Expires At Jan 2, 25, 8:53:15 PM UTC

MSVC-Game__Shipping__Win64 Download Logs
Build Details
Name Information
PR Commit 7867897
Merge Commit 40d1262
Size 28.17 MB
Last Updated Dec 19, 24, 8:54:25 PM UTC
Expires At Jan 2, 25, 8:54:22 PM UTC

@narknon
Copy link
Collaborator

narknon commented Dec 19, 2024

Not sure if relevant to this PR, but it would be nice if when you tried to get data from a table using an incorrect name the log printed out all the actual names in the table. E.g., an out param for a struct that you then want to get a particular value from.

@UE4SS
Copy link
Collaborator Author

UE4SS commented Dec 19, 2024

Not sure if relevant to this PR, but it would be nice if when you tried to get data from a table using an incorrect name the log printed out all the actual names in the table. E.g., an out param for a struct that you then want to get a particular value from.

I'm not prepared to make such a change in this PR.
I'm also not sure how it would be implemented because the table used for out params is provided by the script, and it's just a table.

@UE4SS UE4SS merged commit 1244004 into main Dec 20, 2024
14 checks passed
@UE4SS UE4SS deleted the better-error-msgs branch December 26, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants