feat: Add a health check. #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orakili
approved these changes
Aug 30, 2024
There was a problem hiding this comment.
Thanks. I adjusted the log config file to ensure access logs are logged in the access.log file.
access.log example
2024-08-30 07:59:17,312 - uvicorn.access - INFO - 172.18.0.12:55726 - "POST /text/correlate/keywords HTTP/1.1" 200
2024-08-30 08:05:14,922 - uvicorn.access - INFO - 172.18.0.12:45420 - "GET /status HTTP/1.1" 200
uvicorn.log example
2024-08-30 08:05:01,527 - uvicorn.error - INFO - Shutting down
2024-08-30 08:05:01,634 - uvicorn.error - INFO - Waiting for application shutdown.
2024-08-30 08:05:01,635 - uvicorn.error - INFO - Application shutdown complete.
2024-08-30 08:05:01,635 - uvicorn.error - INFO - Finished server process [8]
2024-08-30 08:05:04,810 - uvicorn.error - INFO - Started server process [48]
2024-08-30 08:05:04,810 - uvicorn.error - INFO - Waiting for application startup.
2024-08-30 08:05:04,810 - uvicorn.error - INFO - Application startup complete.
Note: the logger name for uvicorn is uvicorn.error regardless of whether the log entry is for an error or some info like the statup ones in the example above. See encode/uvicorn#562
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.