Create backend production server for django #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dockerfile.int
Outdated
| @@ -0,0 +1,11 @@ | |||
| FROM python:3.7 | |||
There was a problem hiding this comment.
Let's rename this file to Dockerfile.dev
Dockerfile.int
Outdated
| RUN pip install -r requirements.txt | ||
| COPY . /code/ | ||
| ENV PATH /code/:$PATH | ||
| EXPOSE 8000 |
There was a problem hiding this comment.
Change this to
Suggested change
| EXPOSE 8000 | |
| EXPOSE $PORT |
Since GCP will provide the port number
Dockerfile.prod
Outdated
| RUN pip install -r requirements.txt | ||
| COPY . /code/ | ||
| ENV PATH /code/:$PATH | ||
| EXPOSE 8000 |
There was a problem hiding this comment.
Suggested change
| EXPOSE 8000 | |
| EXPOSE $PORT |
See above
Dockerfile.int
Outdated
| RUN mkdir /code | ||
| WORKDIR /code | ||
| COPY requirements.txt /code/ | ||
| RUN pip install psycopg2-binary==2.8.6 |
There was a problem hiding this comment.
Can we not add this to requirements.txt?
Dockerfile.prod
Outdated
| RUN mkdir /code | ||
| WORKDIR /code | ||
| COPY requirements.txt /code/ | ||
| RUN pip install psycopg2-binary==2.8.6 |
There was a problem hiding this comment.
Can we not add this to requirements.txt
uwpath_backend/int.py
Outdated
| @@ -0,0 +1,183 @@ | |||
| """ | |||
There was a problem hiding this comment.
What's the difference between this file and dev.py?
uwpath_backend/dev.py
Outdated
Comment on lines
82
to
88
| 'default': { | ||
| 'ENGINE': 'django.db.backends.postgresql', | ||
| 'NAME': 'postgres' if os.getenv("DB_NAME") is None else os.getenv("DB_NAME"), | ||
| 'USER': 'postgres' if os.getenv("DB_USER") is None else os.getenv("DB_USER"), | ||
| 'PASSWORD': '1234' if os.getenv("DB_PASS") is None else os.getenv("DB_PASS"), | ||
| 'HOST': 'db' if os.getenv("DB_HOST") is None else os.getenv("DB_HOST"), | ||
| 'PORT': '5432' if os.getenv("DB_PORT") is None else os.getenv("DB_PORT"), |
There was a problem hiding this comment.
Can you change these values to match the db config in our current settings.py file? We migrated from postgres to oracle
uwpath_backend/int.py
Outdated
Comment on lines
100
to
105
| 'ENGINE': 'django.db.backends.postgresql', | ||
| 'NAME': 'postgres' if os.getenv("DB_NAME") is None else os.getenv("DB_NAME"), | ||
| 'USER': 'postgres' if os.getenv("DB_USER") is None else os.getenv("DB_USER"), | ||
| 'PASSWORD': '1234' if os.getenv("DB_PASS") is None else os.getenv("DB_PASS"), | ||
| 'HOST': 'db' if os.getenv("DB_HOST") is None else os.getenv("DB_HOST"), | ||
| 'PORT': '5432' if os.getenv("DB_PORT") is None else os.getenv("DB_PORT"), |
uwpath_backend/prod.py
Outdated
Comment on lines
101
to
106
| 'ENGINE': 'django.db.backends.postgresql', | ||
| 'NAME': 'postgres' if os.getenv("DB_NAME") is None else os.getenv("DB_NAME"), | ||
| 'USER': 'postgres' if os.getenv("DB_USER") is None else os.getenv("DB_USER"), | ||
| 'PASSWORD': '1234' if os.getenv("DB_PASS") is None else os.getenv("DB_PASS"), | ||
| 'HOST': 'db' if os.getenv("DB_HOST") is None else os.getenv("DB_HOST"), | ||
| 'PORT': '5432' if os.getenv("DB_PORT") is None else os.getenv("DB_PORT"), |
Comment on lines
+101
to
+106
| 'ENGINE': 'django.db.backends.postgresql', | ||
| 'NAME': 'postgres' if os.getenv("DB_NAME") is None else os.getenv("DB_NAME"), | ||
| 'USER': 'postgres' if os.getenv("DB_USER") is None else os.getenv("DB_USER"), | ||
| 'PASSWORD': '1234' if os.getenv("DB_PASS") is None else os.getenv("DB_PASS"), | ||
| 'HOST': 'db' if os.getenv("DB_HOST") is None else os.getenv("DB_HOST"), | ||
| 'PORT': '5432' if os.getenv("DB_PORT") is None else os.getenv("DB_PORT"), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.