-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Light entire matrix at the beginning of switch test mode. #1062
Conversation
The issue persists. Have you tested it? |
That last commit fixes only one minor issue that I have found while testing. As for the cause of the invalid key count, I am still in the dark. |
Ok, thanks! As soon as this gets fixed, I'll release a new firmware. |
Long story short, try now. |
On my ANSI UHK 60 v2, in switch test mode, when I press the left Shift, the left ISO Shift LED lights up instead of the ANSI LED. |
I can't reproduce it. Have you powercycled the board after writing that hardware config? Hardware config is still reloaded only after power cycling. |
This PR works when power-cycling my UHK after Can you reload the hardware config with reasonable effort after writing it? Alternatively, we can provide an ansi/iso parameter to testSwitches, but that would be redundant. The bottom line is that I prefer to make factory flashing fast and avoid unnecessary steps, such as a firmware reboot. |
Well, this reloads the led settings when the config is written. I have not tried to update the other settings, such as the serial number though. |
8205d71
to
ce69d89
Compare
Closes #1058