Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Light entire matrix at the beginning of switch test mode. #1062

Merged
merged 6 commits into from
Dec 31, 2024

Conversation

kareltucek
Copy link
Collaborator

Closes #1058

@mondalaci
Copy link
Member

The issue persists. Have you tested it?

@kareltucek
Copy link
Collaborator Author

That last commit fixes only one minor issue that I have found while testing. As for the cause of the invalid key count, I am still in the dark.

@mondalaci
Copy link
Member

Ok, thanks! As soon as this gets fixed, I'll release a new firmware.

@kareltucek
Copy link
Collaborator Author

Long story short, try now.

@mondalaci
Copy link
Member

On my ANSI UHK 60 v2, in switch test mode, when I press the left Shift, the left ISO Shift LED lights up instead of the ANSI LED.

@kareltucek
Copy link
Collaborator Author

I can't reproduce it. Have you powercycled the board after writing that hardware config? Hardware config is still reloaded only after power cycling.

@mondalaci
Copy link
Member

This PR works when power-cycling my UHK after write-hardware-config.ts uhk60v2 ansi but before set-variable.ts testSwitches 1

Can you reload the hardware config with reasonable effort after writing it? Alternatively, we can provide an ansi/iso parameter to testSwitches, but that would be redundant. The bottom line is that I prefer to make factory flashing fast and avoid unnecessary steps, such as a firmware reboot.

@kareltucek
Copy link
Collaborator Author

kareltucek commented Dec 30, 2024

Well, this reloads the led settings when the config is written. I have not tried to update the other settings, such as the serial number though.

@kareltucek kareltucek force-pushed the chance_test_led_ligth_all_behavior branch from 8205d71 to ce69d89 Compare December 30, 2024 23:17
@mondalaci mondalaci merged commit ead30c6 into master Dec 31, 2024
2 checks passed
@mondalaci mondalaci deleted the chance_test_led_ligth_all_behavior branch December 31, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

All LEDs must be lit in switch testing mode
2 participants