Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

netCDFConfig: find HDF5 if needed #2751

Merged
merged 2 commits into from
Oct 25, 2023
Merged

netCDFConfig: find HDF5 if needed #2751

merged 2 commits into from
Oct 25, 2023

Conversation

mathstuf
Copy link
Contributor

@mathstuf mathstuf commented Sep 6, 2023

See: #1733

@mathstuf mathstuf mentioned this pull request Sep 6, 2023
Closed
@WardF WardF self-assigned this Sep 6, 2023
@WardF
Copy link
Member

WardF commented Sep 6, 2023

I have run into issues with disparities between HDF5's cmake integration implementation between Linux/MacOS and Windows in the past. Let me double-check this by hand but looks good!

@mathstuf
Copy link
Contributor Author

mathstuf commented Sep 6, 2023

Agreed. I've run into the issue where NetCDF's references to hdf5_hl-shared targets end up with failure to find a hdf5_hl-shared library on-disk because the target name is never resolved. If there's some way to detect that NetCDF used imported targets from HDF5, then that can be used as the conditional instead.

kmorel
kmorel reviewed Sep 26, 2023
View reviewed changes
netCDFConfig.cmake.in Outdated Show resolved Hide resolved
@ZedThree ZedThree mentioned this pull request Oct 20, 2023
Merged
WardF
WardF previously approved these changes Oct 24, 2023
View reviewed changes
@WardF WardF added this to the 4.9.3 milestone Oct 25, 2023
@WardF WardF merged commit 980c7cf into Unidata:main Oct 25, 2023
97 checks passed
@mathstuf mathstuf deleted the find-hdf5-if-needed branch October 25, 2023 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmorel kmorel kmorel left review comments

@WardF WardF WardF approved these changes

@DennisHeimbigner DennisHeimbigner Awaiting requested review from DennisHeimbigner DennisHeimbigner is a code owner

Assignees

@WardF WardF

Labels
None yet
Projects
None yet
Milestone
4.9.3
Development

Successfully merging this pull request may close these issues.
3 participants
@mathstuf @WardF @kmorel