Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand logic around H5Literate2 data structure use. #2977

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Expand logic around H5Literate2 data structure use. #2977

merged 1 commit into from
Aug 13, 2024

Conversation

WardF
Copy link
Member

@WardF WardF commented Aug 13, 2024

@WardF WardF self-assigned this Aug 13, 2024
@WardF WardF mentioned this pull request Aug 13, 2024
Merged
13 tasks
@WardF
Copy link
Member Author

WardF commented Aug 13, 2024

Note to self, tested against HDF5 1.10.10 and 1.14.4 to check logic around the presence and absence of H5Literate2.

@WardF WardF merged commit 0244e3c into Unidata:main Aug 13, 2024
107 checks passed
@WardF WardF deleted the h5literate2_pointer.wif branch August 13, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwardhartnett edwardhartnett edwardhartnett left review comments

@DennisHeimbigner DennisHeimbigner Awaiting requested review from DennisHeimbigner DennisHeimbigner is a code owner

Assignees

@WardF WardF

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clang issue with H5Literate2 and incompatible pointer logic.
2 participants
@WardF @edwardhartnett