Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

example multifiller executor #272

Merged
merged 7 commits into from
Dec 18, 2024
Merged

example multifiller executor #272

merged 7 commits into from
Dec 18, 2024

Conversation

ConjunctiveNormalForm
Copy link
Member

No description provided.

zhongeric
zhongeric reviewed Aug 29, 2024
View reviewed changes
Copy link
Collaborator

@zhongeric zhongeric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add the withdrawERC20 permissioned functions too? And the ability to change reactor / swapRouter02 to the owner

zhongeric
zhongeric previously approved these changes Aug 29, 2024
View reviewed changes
zhongeric
zhongeric previously approved these changes Sep 11, 2024
View reviewed changes
@ConjunctiveNormalForm ConjunctiveNormalForm marked this pull request as ready for review December 18, 2024 17:09
codyborn
codyborn previously approved these changes Dec 18, 2024
View reviewed changes
Copy link
Collaborator

@codyborn codyborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I'd just add a sample command to encode the array of addresses to make it easier for the user.

@ConjunctiveNormalForm ConjunctiveNormalForm merged commit 2954f97 into main Dec 18, 2024
3 checks passed
@codyborn codyborn deleted the multi-filler-executor-l2 branch December 18, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhongeric zhongeric zhongeric left review comments

@codyborn codyborn codyborn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ConjunctiveNormalForm @codyborn @zhongeric