Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update the FOT detector to check for external fees #24

Merged
merged 23 commits into from
Jun 28, 2024

Conversation

zhongeric
Copy link
Contributor

@zhongeric zhongeric commented May 22, 2024

Update the existing FOT detector contract to check for two scenarios:

  1. when a fee is applied on a transfer NOT to or from the V2 pair
  2. when a token transfer done within the context of an existing swap reverts

The returned data now includes two new bools at the end of the struct

@marktoda
Copy link
Collaborator

tests failing?

Copy link
Collaborator

@marktoda marktoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

src/FeeOnTransferDetector.sol Outdated Show resolved Hide resolved
src/FeeOnTransferDetector.sol Outdated Show resolved Hide resolved
src/FeeOnTransferDetector.sol Outdated Show resolved Hide resolved
@zhongeric zhongeric merged commit 4ce5b58 into main Jun 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants