Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: upgrade to 2022.3.14f1 & NGO v1.7.1 [MTT-7763] #871

Merged
merged 6 commits into from
Dec 12, 2023
Merged

feat: upgrade to 2022.3.14f1 & NGO v1.7.1 [MTT-7763] #871

merged 6 commits into from
Dec 12, 2023

Conversation

fernando-cortez
Copy link
Collaborator

@fernando-cortez fernando-cortez commented Dec 8, 2023 •
edited
Loading

Description

This PR upgrades Boss Room to the newest LTS, 2022.3.14f1, as well as Netcode for GameObjects v1.7.1.

Issue Number(s)

MTT--7763

Contribution checklist

  • [ N/A ] Tests have been added for boss room and/or utilities pack
  • Release notes have been added to the project changelog file and/or package changelog file
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • JIRA ticket ID is in the PR title or at least one commit message
  • Include the ticket ID number within the body message of the PR to create a hyperlink
  • [ N/A ] An Index entry has been added in readme.md if applicable

@fernando-cortez fernando-cortez added 2-Easy This PR is trivial and can be reviewed quickly 1-Needs Review PR needs attention from the assignee and reviewers labels Dec 8, 2023
@fernando-cortez fernando-cortez marked this pull request as ready for review December 8, 2023 21:52
@fernando-cortez fernando-cortez requested a review from a team as a code owner December 8, 2023 21:52
@fernando-cortez fernando-cortez requested review from a team and removed request for a team December 11, 2023 19:37
@fernando-cortez
Copy link
Collaborator Author

For those reviewing, I've added the fix for playmode tests that were suggested by Noel in this PR.

@jilfranco-unity
Copy link
Contributor

did a quick play through with host and client both with lobby and IP, didn't see any issues! also checked shaders for any warnings (sometimes you see them with editor version upgrades) and they all check out too ✨

@jilfranco-unity jilfranco-unity self-requested a review December 12, 2023 22:33
jilfranco-unity
jilfranco-unity approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@jilfranco-unity jilfranco-unity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked with updated quality settings, all good!

@fernando-cortez fernando-cortez merged commit 95d1c12 into develop Dec 12, 2023
12 checks passed
@fernando-cortez fernando-cortez deleted the feat/upgrade-NGO-LTS branch December 12, 2023 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jilfranco-unity jilfranco-unity jilfranco-unity approved these changes

Assignees
No one assigned
Labels
1-Needs Review PR needs attention from the assignee and reviewers 2-Easy This PR is trivial and can be reviewed quickly
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fernando-cortez @jilfranco-unity