Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release: v2.4.0 #872

Merged
merged 6 commits into from
Dec 13, 2023
Merged

release: v2.4.0 #872

merged 6 commits into from
Dec 13, 2023

Conversation

fernando-cortez
Copy link
Collaborator

@fernando-cortez fernando-cortez commented Dec 13, 2023 •
edited
Loading

Description

Updating project and package settings for release.
Changelog additions were made more verbose.
Documentation images for readme were updated as well.

Issue Number(s)

N/A

Contribution checklist

  • [ N/A ] Tests have been added for boss room and/or utilities pack
  • Release notes have been added to the project changelog file and/or package changelog file
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • [ N/A ] JIRA ticket ID is in the PR title or at least one commit message
  • [ N/A ] Include the ticket ID number within the body message of the PR to create a hyperlink
  • An Index entry has been added in readme.md if applicable

@fernando-cortez
fix: NetworkVariable warnings on player spawns [MTT-7161] (#870)
2a68293 
* netvar instantiation pre-spawn

* changelog addition
@fernando-cortez
Merge branch 'main' into develop
006512b
@fernando-cortez
feat: upgrade to 2022.3.14f1 & NGO v1.7.1 [MTT-7763] (#871)
95d1c12 
* upgrade project to 2022.3.14f1 LTS

* upgrade to NGO v1.7.1

* changelog addition

* upgrading Utilities package to NGO v1.7.1

* adding Noel's fix for failing test

* updated URP & project settings
@fernando-cortez
project updated for v2.4.0 release
beac39e
@fernando-cortez fernando-cortez added the 1-Needs Review PR needs attention from the assignee and reviewers label Dec 13, 2023
@fernando-cortez fernando-cortez requested a review from a team December 13, 2023 18:37
@fernando-cortez fernando-cortez marked this pull request as ready for review December 13, 2023 19:24
@fernando-cortez fernando-cortez requested a review from a team as a code owner December 13, 2023 19:24
@fernando-cortez fernando-cortez changed the base branch from develop to main December 13, 2023 19:54
jilfranco-unity
jilfranco-unity approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@jilfranco-unity jilfranco-unity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! :)

@fernando-cortez fernando-cortez merged commit e48babb into main Dec 13, 2023
2 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jilfranco-unity jilfranco-unity jilfranco-unity approved these changes

Assignees
No one assigned
Labels
1-Needs Review PR needs attention from the assignee and reviewers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fernando-cortez @jilfranco-unity