release: v2.5.0 #887
Merged
release: v2.5.0 #887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#880) * Added null reference check to ClientInputSender script * Fixed whitepsace issue * Update CHANGELOG.md * Update CHANGELOG.md pr number * Revert "Fixed whitepsace issue" This reverts commit edc03c3. * fix line 478 * Update CHANGELOG.md Co-authored-by: Fernando Cortez <[email protected]> --------- Co-authored-by: Fernando Cortez <[email protected]>
…87] [MTT-5711] (#879) * changed sort layer of popup panel to bring it to the front * panel sort order adjustments to fix RNSM hidden under loading screen issue * fix settings UI order * changed UI canvas sort order to -1 to fix small issue * Update CHANGELOG.md with PR number * Revert "changed UI canvas sort order to -1 to fix small issue" This reverts commit d399dc8. * changed MainMenu UI Canvas to -1 * adjusted sort order according to jils suggestion Sort Orders: PopUpPanel = 1 Loading Screen = 0 SettingsPanel Canvas = -1 Boss Room HUD = -2 Main Menu UI Canvas = -3 UI Root (PostGame) = -3 * update NetStatsMonitorPrefab sort order to -3 fixed that it does not block join game option on startup * updated CharacterSelectCanvas sort order to -2 * changed NSMPCanvas to scale with screen size and adjusted text size to 45 * addressed feedback and adjusted RNSM size, created UIRoot prefab * added UI toolkit theme to make new RNSMSettings asset work * enabled sort order override and adjusted sorting order of MessageWindow.prefab to -1 and renamed UIRoot to PostGameUICanvas
…sembly includes Unity.Collections [MTT-8188] (#883) * upgrade to NGO v1.8.1, conversion to universal Rpcs, utility assembly includes Unity.Collections * fix for connected clients receiving new shutdown message from host * Utilities package also upgraded to NGO v1.8.1 * changelog additions * readme badge with NGO upgrade updated * added Server/Client prefixes for previous Rpc methods * update to Utilities changelog * using RpcTargetUse Temp since clientId may change frequently
* upgrade to 2022.3.22f1 LTS * changelog addition * setting yamato tests to 2022.3 * fixing the ClientLoadingScreen ondestroy null reference
…onizations [MTT-3152] (#886) * ClientPlayerAvatarNetworkAnimator introduced to handle client syncs * reformat class * format * changelog addition
fernando-cortez
added
the
1-Needs Review
|
The changes and version numbers look good to me! The only thing I found were the errors (see picture below) when trying to join in a build with the same profile (does not let you as profile already used) and then changing to another profile and joining (now being allowed to join). Is this error expected?
|
Elfi0Kuhndorf
approved these changes
Apr 18, 2024
So the flow seems like it's correct? If so, let's create a ticket to review that error being logged post-release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
v2.5.0 release changes including changelogs, readme, and project version.
Issue Number(s)
MTT-8318
Contribution checklist