Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Unity 6 [MTT-9275] #890

Merged
merged 38 commits into from
Nov 20, 2024
Merged

Upgrade to Unity 6 [MTT-9275] #890

merged 38 commits into from
Nov 20, 2024

Conversation

FabianStoll
Copy link

@FabianStoll FabianStoll commented Nov 5, 2024

Description

This PR upgrades Boss Room to the newly released Unity 6 LTS, specifically version 6000.0.25f1.
It also includes an upgrade of the Netcode for GameObjects package to version 2.0.0.

With the release of Unity 6 the Multiplayer Play Mode package is now available to simulate up to four virtual players in the Editor for better multiplayer testing. We have replaced ParrelSync with Multiplayer Play Mode.

Issue Number(s)

MTT-9275
MTT-8706

Contribution checklist

  • Tests have been added for boss room and/or utilities pack
  • Release notes have been added to the project changelog file and/or package changelog file
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • JIRA ticket ID is in the PR title or at least one commit message
  • Include the ticket ID number within the body message of the PR to create a hyperlink
  • An Index entry has been added in readme.md if applicable

@unity-cla-assistant
Copy link

unity-cla-assistant commented Nov 5, 2024

CLA assistant check
All committers have signed the CLA.

@FabianStoll FabianStoll changed the base branch from main to develop November 5, 2024 10:49
@FabianStoll FabianStoll force-pushed the feat/unity-6-upgrade branch 2 times, most recently from 88bba75 to 3de1929 Compare November 5, 2024 15:01
@FabianStoll FabianStoll marked this pull request as ready for review November 6, 2024 09:00
@FabianStoll FabianStoll requested a review from a team as a code owner November 6, 2024 09:00
Copy link
Collaborator

@fernando-cortez fernando-cortez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes to make!
I had a few warnings when I opened the project for deprecated API. Those should probably be addressed with this upgrade -- I'll send those offline.

Assets/DefaultVolumeProfile.asset.meta Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
fernando-cortez
fernando-cortez previously approved these changes Nov 7, 2024
Copy link
Collaborator

@fernando-cortez fernando-cortez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!
I created a task to go through the rest of the warnings.
Let's wait to hear back from QA on the Android test.

@fernando-cortez fernando-cortez self-requested a review November 20, 2024 15:07
Copy link
Collaborator

@fernando-cortez fernando-cortez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make a ticket to bump up the editor version when it's okay to do so.
Otherwise, good to go!

@fernando-cortez fernando-cortez merged commit 3dfcd47 into develop Nov 20, 2024
13 checks passed
@fernando-cortez fernando-cortez deleted the feat/unity-6-upgrade branch November 20, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants