-
Notifications
You must be signed in to change notification settings - Fork 513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MTT-8924] - Convert Boss Room from Lobby and Relay packages to Multiplayer Services SDK #892
Merged
fernando-cortez
merged 60 commits into
develop
from
feat/convert-to-multiplayer-services-sdk
Dec 3, 2024
Merged
[MTT-8924] - Convert Boss Room from Lobby and Relay packages to Multiplayer Services SDK #892
fernando-cortez
merged 60 commits into
develop
from
feat/convert-to-multiplayer-services-sdk
Dec 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t-to-multiplayer-services-sdk # Conflicts: # Packages/packages-lock.json
…en connecting via IP
Co-authored-by: Fernando Cortez <[email protected]>
# Conflicts: # .yamato/project.metafile # CHANGELOG.md # Packages/manifest.json # Packages/packages-lock.json # README.md
FabianStoll
requested review from
fernando-cortez
and removed request for
a team
November 21, 2024 13:51
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Few small comments to get to, but overall an awesome upgrade!
Assets/Scripts/ConnectionManagement/ConnectionState/OfflineState.cs
Outdated
Show resolved
Hide resolved
Assets/Scripts/UnityServices/Sessions/MultiplayerServicesFacade.cs
Outdated
Show resolved
Hide resolved
Packages/com.unity.multiplayer.samples.coop/Utilities/Net/UnityRelayUtilities.cs
Show resolved
Hide resolved
Co-authored-by: Fernando Cortez <[email protected]>
Assets/Scripts/UnityServices/Sessions/MultiplayerServicesFacade.cs
Outdated
Show resolved
Hide resolved
Assets/Scripts/UnityServices/Sessions/MultiplayerServicesFacade.cs
Outdated
Show resolved
Hide resolved
fernando-cortez
approved these changes
Dec 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the standalone Lobby and Relay packages in favor of the Multiplayer Services SDK.
Most code changes are renamings from "Lobby" to "Session", including UI text, GameObjects and Prefabs (take note that renamed classes may appear as new files in GIT).
The Readme and Changelog have also been changed accordingly to not mention the standalone packages anymore.
The API for creating, joining, querying and leaving a lobby/session including events was converted accordingly and the exception handling was revised.
Issue Number(s)
[MTT-8924]
Contribution checklist