Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MTT-8924] - Convert Boss Room from Lobby and Relay packages to Multiplayer Services SDK #892

Merged
merged 60 commits into from
Dec 3, 2024

Conversation

FabianStoll
Copy link

Description

This PR removes the standalone Lobby and Relay packages in favor of the Multiplayer Services SDK.
Most code changes are renamings from "Lobby" to "Session", including UI text, GameObjects and Prefabs (take note that renamed classes may appear as new files in GIT).

The Readme and Changelog have also been changed accordingly to not mention the standalone packages anymore.

The API for creating, joining, querying and leaving a lobby/session including events was converted accordingly and the exception handling was revised.

Issue Number(s)

[MTT-8924]

Contribution checklist

  • Tests have been added for boss room and/or utilities pack
  • Release notes have been added to the project changelog file and/or package changelog file
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • JIRA ticket ID is in the PR title or at least one commit message
  • Include the ticket ID number within the body message of the PR to create a hyperlink
  • An Index entry has been added in readme.md if applicable

fernando-cortez and others added 30 commits April 5, 2024 18:01
…t-to-multiplayer-services-sdk

# Conflicts:
#	Packages/packages-lock.json
Co-authored-by: Fernando Cortez <[email protected]>
# Conflicts:
#	.yamato/project.metafile
#	CHANGELOG.md
#	Packages/manifest.json
#	Packages/packages-lock.json
#	README.md
@FabianStoll FabianStoll marked this pull request as ready for review November 21, 2024 13:51
@FabianStoll FabianStoll requested a review from a team as a code owner November 21, 2024 13:51
@FabianStoll FabianStoll requested review from fernando-cortez and removed request for a team November 21, 2024 13:51
Copy link
Collaborator

@fernando-cortez fernando-cortez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Few small comments to get to, but overall an awesome upgrade!

Assets/Scripts/ConnectionManagement/ConnectionMethod.cs Outdated Show resolved Hide resolved
Assets/Scripts/ConnectionManagement/ConnectionMethod.cs Outdated Show resolved Hide resolved
Assets/Scripts/ConnectionManagement/ConnectionMethod.cs Outdated Show resolved Hide resolved
Assets/Scripts/Gameplay/UI/Session/SessionUIMediator.cs Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@fernando-cortez fernando-cortez added the 2-Reviewed with Comments PR requires owner's attention label Nov 25, 2024
Copy link
Collaborator

@fernando-cortez fernando-cortez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@fernando-cortez fernando-cortez merged commit 9a1ca64 into develop Dec 3, 2024
13 checks passed
@fernando-cortez fernando-cortez deleted the feat/convert-to-multiplayer-services-sdk branch December 3, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2-Reviewed with Comments PR requires owner's attention
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants