chore: swap out leaky yggdrasil custom strategy for an internal abstraction #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sighphyre
changed the title
daveleek
reviewed
Nov 5, 2024
| { | ||
| if (settings.FileSystem == null) | ||
| { | ||
| settings.FileSystem = new FileSystem(settings.Encoding); | ||
| } | ||
|
|
||
| engine = new YggdrasilEngine(strategies); | ||
| List<Yggdrasil.IStrategy> yggdrasilStrategies = strategies?.Select(s => new CustomStrategyAdapter(s)).Cast<Yggdrasil.IStrategy>().ToList(); |
There was a problem hiding this comment.
the s as IStrategy didn't work here?
There was a problem hiding this comment.
Ah, never mind.
The barebones interface doesn't work because the method signature requires an Yggdrasil type - the Context.
There was a problem hiding this comment.
I'm not sure what you mean? Does that add anything over the cast?
Edit: Nevermind xD, responded before I saw the update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an adaptor for Yggdrasil -> Legacy strategies so we don't have to leak out Yggdrasil abstractions. The barebones interface doesn't work because the method signature requires an Yggdrasil type - the Context.
Not tested automatically because it's all just plumbing but most of the existing tests already cover the Unleash constructor and manually tested through the example project