Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: variant stickiness from strategy #570

Merged
merged 1 commit into from
Jan 23, 2024
Merged

fix: variant stickiness from strategy #570

merged 1 commit into from
Jan 23, 2024

Conversation

kwasniew
Copy link
Contributor

@kwasniew kwasniew commented Jan 23, 2024 •
edited
Loading

About the changes

If variant doesn't have stickiness fall back to strategy stickiness.

Fixes updated and failing spec: Unleash/client-specification#83

Important files

Discussion points

@github-actions GitHub Actions
Copy link

Coverage Status

coverage: 91.026% (+0.02%) from 91.003%
when pulling d23e07d on fix-variants-stickiness-from-strategy
into 8fa90e2 on main.

FredrikOseberg
FredrikOseberg approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@FredrikOseberg FredrikOseberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kwasniew kwasniew merged commit da6120b into main Jan 23, 2024
5 checks passed
@kwasniew kwasniew deleted the fix-variants-stickiness-from-strategy branch January 23, 2024 15:09
@nunogois nunogois mentioned this pull request Sep 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FredrikOseberg FredrikOseberg FredrikOseberg approved these changes

@ivarconr ivarconr Awaiting requested review from ivarconr

@sighphyre sighphyre Awaiting requested review from sighphyre

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kwasniew @FredrikOseberg