feat: extend metrics and registration with optional metadata #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriswk
reviewed
Jul 18, 2024
| "environment": "some-instance", | ||
| "instanceId": "something", | ||
| "interval": 15000, | ||
| "started": "1867-11-07T12:00:00Z", |
There was a problem hiding this comment.
Marie Curie's birthday :)
sighphyre
force-pushed
the
chore/make-tests-easier-to-patch
branch
from
0e366b4 to
db9b7d9
Compare
sighphyre
force-pushed
the
chore/extend-metrics-for-types
branch
from
a0a7390 to
dd2a966
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends the metrics and registration structs to accept metadata fields for the new metrics we want to ingest.
I've chosen to make this type non optional - you really should be filling in these fields when you're ingesting this data. The serialization, however, will happily ignore the missing fields. This is all rolled up into a single flattened struct so that it's easier to keep these fields together
Depends on #38 and #39 - kept separate from these because those facilitate making the logic change smaller