feat: read logs and update cors maintenance root-role permissions #8996
+144
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
Tymek
force-pushed
the
feat/more-maintenance-permissions
branch
from
343a857 to
f8a62ef
Compare
|
@Tymek, core features have been modified in this pull request. Please review carefully! |
github-actions
bot
requested review from
chriswk,
FredrikOseberg,
gastonfournier and
ivarconr
Tymek
commented
Dec 19, 2024
Comment on lines
+222
to
245
| async setCors( | ||
| req: IAuthRequest<void, void, SetCorsSchema>, | ||
| res: Response<string>, | ||
| ): Promise<void> { | ||
| const granularAdminPermissions = this.flagResolver.isEnabled( | ||
| 'granularAdminPermissions', | ||
| ); | ||
|
|
||
| if (!granularAdminPermissions) { | ||
| throw new NotFoundError(); | ||
| } | ||
|
|
||
| if (req.body.frontendApiOrigins) { | ||
| await this.frontendApiService.setFrontendCorsSettings( | ||
| req.body.frontendApiOrigins, | ||
| req.audit, | ||
| ); | ||
| res.sendStatus(204); | ||
| return; | ||
| } | ||
|
|
||
| throw new NotFoundError(); | ||
| } | ||
| } |
There was a problem hiding this comment.
Previous "setUiConfig" is a generic name, but it only sets CORS. For easy transition into endpoint with proper permissions it's easier to create new one, and avoid potential errors or confusion about permissions in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
Closes #
Important files
Discussion points