引数のVoicevoxUserDictWord*がunalignedであることを許す
#601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qryxip
commented
Sep 8, 2023
| @@ -956,6 +956,7 @@ pub struct VoicevoxUserDict { | |||
| } | |||
|
|
|||
| /// ユーザー辞書の単語。 | |||
| #[derive(Clone, Copy)] | |||
There was a problem hiding this comment.
ここは実は無くても動く(初めて知った)、がread(_unaligned)でCopyしてはいけないオブジェクトをCopyしてしまったら流石にUBなので、ドキュメンテーション的な観点から付けておくことにする。
readcreates a bitwise copy ofT, regardless of whetherTisCopy. IfTis notCopy, using both the returned value and the value at*srccan violate memory safety. Note that assigning to*srccounts as a use because it will attempt to drop the value at*src.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
#534 の方針を継続し、FIXMEとしていた部分を解消します。
関連 Issue
その他
というより
VoicevoxUserDictWordはby valueで渡した方がよいかもしれません。