download_testをデフォルトでprerelease込みのlatestが使われるように変更 #608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hiroshiba
commented
Sep 12, 2023
Comment on lines
+12
to
+13
| env: | ||
| VERSION: "prerelease-latest" |
There was a problem hiding this comment.
後々このバージョンを引数で指定可能にしたいので、workflowのenvとしてここに配置しています。
Comment on lines
-172
to
-175
| env: | ||
| EXPECTED_VOICEVOX_CORE_VERSION: latest | ||
| # See https://github.com/VOICEVOX/voicevox_core/issues/310 | ||
| #EXPECTED_VOICEVOX_CORE_VERSION: ${{ matrix.expected_version || 'latest' }} |
There was a problem hiding this comment.
元々はダウンロードされたバージョンのチェックとして使われていたのを、バージョン指定できるようにしたので、EXPECTED_VOICEVOX_CORE_VERSIONという名前からVERSIONという名前に変更しています。
| steps: | ||
| - uses: actions/checkout@v3 | ||
| - name: Set up Rust | ||
| if: ${{ startsWith(matrix.download_command, 'cargo ') }} |
There was a problem hiding this comment.
前のプルリクエストで必ずcargo が入るものしかなくなっていたのに気づいたので除去
Comment on lines
+181
to
+182
| - name: Get prerelease latest version | ||
| if: ${{ env.VERSION == 'prerelease-latest' }} |
There was a problem hiding this comment.
正確にはプレリリースの最新ではなく、プレリリースを含む最新なので、ちょっと名称が紛らわしいかも
This was referenced Sep 12, 2023
qryxip
reviewed
Sep 14, 2023
Co-authored-by: Ryo Yamashita <[email protected]>
|
レビューありがとうございます！！ |
Hiroshiba
deleted the
download_testがデフォルトでprerelease込みのlatestを参照するように変更
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
ダウンローダーのテストはいつもlatestを見ているので、ダウンロード内容が変わった時にテストが必ず落ちるようになっています。
#603 (comment)
プレリリースを含んだリリースのlatestを使うようにすれば、プレリリースしさえすればテストが落ちないようにすることができるはずなので、その提案を含めてプルリクエストを作ってみました。
関連 Issue
その他