Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor patches #542

Merged
merged 2 commits into from
Jan 9, 2024
Merged

Minor patches #542

merged 2 commits into from
Jan 9, 2024

Conversation

fcogidi
Copy link
Collaborator

@fcogidi fcogidi commented Jan 9, 2024

PR Type

Fix.

Short Description

  • Fix capitalization of 'Python'.
  • Change ValueError to TypeError

Tests Added

None

@fcogidi fcogidi added the refactor Refactor existing code, with same or similar functionality label Jan 9, 2024
Copy link

codecov bot commented Jan 9, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (802874b) 68.67% compared to head (b6f7713) 68.67%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #542   +/-   ##
=======================================
  Coverage   68.67%   68.67%           
=======================================
  Files         108      108           
  Lines       10177    10177           
=======================================
  Hits         6989     6989           
  Misses       3188     3188           
Files Coverage Δ
...aluate/metrics/experimental/functional/accuracy.py 100.00% <ø> (ø)
...valuate/metrics/experimental/functional/f_score.py 98.36% <ø> (ø)
...perimental/functional/negative_predictive_value.py 100.00% <ø> (ø)
...etrics/experimental/functional/precision_recall.py 100.00% <ø> (ø)
...ate/metrics/experimental/functional/specificity.py 100.00% <ø> (ø)
cyclops/evaluate/metrics/experimental/metric.py 82.81% <100.00%> (ø)
...clops/evaluate/metrics/experimental/metric_dict.py 92.61% <ø> (ø)
cyclops/models/wrappers/utils.py 80.35% <ø> (ø)
cyclops/report/model_card/base.py 64.58% <ø> (ø)
.../evaluate/metrics/experimental/utils/validation.py 84.44% <0.00%> (ø)

Impacted file tree graph

@fcogidi fcogidi merged commit 6965603 into main Jan 9, 2024
8 of 9 checks passed
@fcogidi fcogidi deleted the minor_patches branch January 9, 2024 23:23
rjavadi pushed a commit that referenced this pull request Jan 30, 2024
* Fix capitalization of Python

* Change ValueError to TypeError and update docstrings
amrit110 added a commit that referenced this pull request Feb 11, 2024
* Changed documentation theme to sphinx-book-theme

* Added details about Pandoc requirment

* Added initial document for accuracy.py

* Fix pre-commit hook errors

* Added confusion matrix doc

* Add auroc doc and fix titles

* Add average precision docs

* Added more documents for metrics

* Add index for user guide in side bar

* Minor patches (#542)

* Fix capitalization of Python

* Change ValueError to TypeError and update docstrings

* Add Precision-Recall Curve to experimental metrics (#544)

* Add ROC curve (#545)

* Add ROC metrics to experimental module

* fix typo

* Fix docstrings

* Add AUROC (#546)

* Add AUROC metric to experimental module

* Refactor binary and multiclass ROC functions

* Refactor tests to use a common thresholds list

* Fix mypy error

* Add regression metrics (#547)

* Add regression support

* update docstrings

* Ignore `no-any-return` errors

* Integrate experimental metrics with other modules (#549)

* integrate experimental metrics with other modules

* add average precision metric to experimental metrics package

* fix tutorials

* Add type hints and keyword arguments to metrics classes

* Update nbsphinx version to 0.9.3

* Update nbconvert version to 7.14.2

* Fix type annotations and formatting issues

* Update kernel display name in mortality_prediction.ipynb

* Add guard clause to prevent module execution on import

* Update `torch_distributed.py` with type hints

* Add multiclass and multilabel average precision metrics

* Change jupyter kernel

* Fix type annotations for metric values in ClassificationPlotter

---------

Co-authored-by: Amrit K <[email protected]>

* Changed documentation theme to sphinx-book-theme

* Don't update deps

* Pre-commit fixes

* Add doc for ROC Curve

* Fix footer in docs

* Bump to 0.2.3

Signed-off-by: Amrit Krishnan <[email protected]>

* Add logo and css fixes

* Fix formatting of conf.py file

* Small fix

* Move evaluation metrics docs under API reference

* Fix poetry build

* Improve documentation structure

* Formatting fixes

---------

Signed-off-by: Amrit Krishnan <[email protected]>
Co-authored-by: Franklin <[email protected]>
Co-authored-by: Amrit K <[email protected]>
Co-authored-by: Amrit Krishnan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactor existing code, with same or similar functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant