Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Redis Password Input #45

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Added Redis Password Input #45

wants to merge 3 commits into from

Conversation

MomoMiles
Copy link

Changelog

Redis Allows Passwords

Allowed a redis password to be inputted into the bot, preventing an error lacking authentication.

File Changes

  1. globals/globals.go
    • Added REDIS_PASS as variable
  2. .env.example
    • Added REDIS_PASS as example variable
  3. main.go
    • Added error for missing password to client console
  4. routes/discord.go
    • Added error for missing password to client console

Added the ability to input a redis password if the user has one.

Changes:
Redis_Pass=
@lewisakura
Copy link
Member

This isn't necessary in the supported Vencloud deployment since it runs its own isolated Redis instance. Why do you need this?

@MomoMiles
Copy link
Author

MomoMiles commented Oct 12, 2024 via email

@MomoMiles
Copy link
Author

For my case also, I run unraid, so i built the redis container separate from the vencloud container. I could've done it differently, but personally it allowed more control within the unraid panel that way.

@lewisakura
Copy link
Member

Been a while, but just got around to checking this again.

Can you modify this so that it tests and errors if Redis authentication fails? Errors like those shouldn't be publicly shown.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants