Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: auto minimize on auto start + dbus #282

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

lewisakura
Copy link
Member

No description provided.

@lewisakura lewisakura marked this pull request as draft December 9, 2023 23:01
@lewisakura lewisakura changed the title fix: make minimize only run on autostart fix: auto minimize on auto start + dbus Dec 9, 2023
[Desktop Entry]
Type=Application
Version=1.0
Name=Vencord
Comment=Vencord autostart script
Exec=${process.execPath}
Exec=${process.execPath} --autostart
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe this would be slightly more self explanatory

Suggested change
Exec=${process.execPath} --autostart
Exec=${process.execPath} --is-autostart=true

enable() {
const desktopFile = `
if (isFlatpak) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if this logic is good. why not unconditionally first try using the portal and if it doesn't work, use the desktop fallback instead? lots of DEs implement the portal so it should work on those even without flatpak, no?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i havent tested gdbus yet fully so this is just placeholder code

@Vendicated
Copy link
Member

Vendicated commented Jan 16, 2024

could u rebase on #322 ?

@Vendicated Vendicated mentioned this pull request Mar 12, 2024
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants