Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ServerInfo): don't display avatar in modal when MentionAvatars is enabled #2762

Closed
wants to merge 2 commits into from

Conversation

ryanccn
Copy link
Contributor

@ryanccn ryanccn commented Aug 5, 2024

Before After
before after

src/plugins/serverInfo/GuildInfoModal.tsx Outdated Show resolved Hide resolved
src/plugins/serverInfo/GuildInfoModal.tsx Outdated Show resolved Hide resolved
@ryanccn ryanccn requested a review from Nuckyz August 6, 2024 13:33
@ryanccn ryanccn force-pushed the serverinfo-mentionavatars-fix branch 2 times, most recently from 7d7c6f3 to 2c79a3d Compare August 14, 2024 10:35
@ryanccn ryanccn force-pushed the serverinfo-mentionavatars-fix branch 2 times, most recently from 3158c02 to aae9f3d Compare August 20, 2024 10:40
@Vendicated
Copy link
Owner

why is it so squished :o

maybe it would be better to instead make the MentionAvatars plugin not apply to that location

@ryanccn ryanccn force-pushed the serverinfo-mentionavatars-fix branch 5 times, most recently from 74a5fb2 to 2e6e94a Compare September 4, 2024 01:07
@ryanccn ryanccn force-pushed the serverinfo-mentionavatars-fix branch from 2e6e94a to 509edf4 Compare September 4, 2024 14:28
@Vendicated
Copy link
Owner

thanks but superseded by e6994e1

@Vendicated Vendicated closed this Sep 5, 2024
@ryanccn ryanccn deleted the serverinfo-mentionavatars-fix branch September 5, 2024 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants