Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update return type of validate function #79

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update return type of validate function #79

wants to merge 2 commits into from

Conversation

c0sx
Copy link

@c0sx c0sx commented Sep 19, 2023

closes #59

@c0sx c0sx marked this pull request as draft September 19, 2023 16:04
@c0sx c0sx marked this pull request as ready for review September 19, 2023 16:05
@c0sx
Copy link
Author

c0sx commented Oct 10, 2023

@mjturt I'm sorry, could you check this PR please?

@c0sx
Copy link
Author

c0sx commented Jan 19, 2024

@mjturt sorry for bothering. Should I do something to release this PR?

@velocityzen
Copy link

release this fix please!

@mjturt
Copy link
Member

mjturt commented Dec 27, 2024

I'm sorry it has taken so long. I'll try to find someone with write access to get this finally published (I don't have).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjturt mjturt mjturt approved these changes

@veckatimest veckatimest veckatimest approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid return type of validate function in constructor property.
4 participants
@c0sx @velocityzen @mjturt @veckatimest