Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VCST-2507: Sorted product configuration sections in XAPI #28

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

VCST-2507: Sorted product configuration sections in XAPI #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/VirtoCommerce.XCart.Core/Models/ExpConfigurationSection.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ public class ExpProductConfigurationSection
{
public string Id { get; set; }
public string Name { get; set; }
public string Type { get; set; }
public string Description { get; set; }
public bool IsRequired { get; set; }

Expand Down
3 changes: 1 addition & 2 deletions src/VirtoCommerce.XCart.Core/Schemas/ConfigurationSectionType.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
using GraphQL.Types;
using GraphQL.Types;
using VirtoCommerce.Xapi.Core.Schemas;
using VirtoCommerce.XCart.Core.Models;

Expand All @@ -10,7 +10,6 @@ public ConfigurationSectionType()
{
Field(x => x.Id, nullable: false).Description("Configuration section id");
Field(x => x.Name, nullable: true).Description("Configuration section name");
Field(x => x.Type, nullable: true).Description("Configuration section type");
Field(x => x.Description, nullable: true).Description("Configuration section description");
Field(x => x.IsRequired, nullable: false).Description("Is configuration section required");

Expand Down
2 changes: 1 addition & 1 deletion src/VirtoCommerce.XCart.Data/Queries/GetProductConfigurationQueryHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ public async Task<ProductConfigurationQueryResponse> Handle(GetProductConfigurat

var productByIds = cartProducts.ToDictionary(x => x.Product.Id, x => x);

foreach (var section in configuration.Sections)
foreach (var section in configuration.Sections.OrderBy(x => x.DisplayOrder))
{
var configurationSection = new ExpProductConfigurationSection
{
Expand Down
Loading