-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Improve handling for parallel Scala CLI runs #3399
Draft
Gedochao
wants to merge
5
commits into
VirtusLab:main
Choose a base branch
from
Gedochao:maintenance/fix-parallel-cli-runs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[WIP] Improve handling for parallel Scala CLI runs #3399
Gedochao
wants to merge
5
commits into
VirtusLab:main
from
Gedochao:maintenance/fix-parallel-cli-runs
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gedochao
force-pushed
the
maintenance/fix-parallel-cli-runs
branch
from
December 31, 2024 08:50
97b9c5c
to
6c9bdaa
Compare
tgodzik
reviewed
Dec 31, 2024
@@ -37,8 +38,10 @@ object Bloop { | |||
): Either[Throwable, Boolean] = | |||
try { | |||
logger.debug("Listing BSP build targets") | |||
val results = buildServer.workspaceBuildTargets() | |||
.get(buildTargetsTimeout.length, buildTargetsTimeout.unit) | |||
val results = retry()(logger) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Och, this can also fail?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup, thus the ExecutionException
catch case 😞
…er of processes to 6
Gedochao
force-pushed
the
maintenance/fix-parallel-cli-runs
branch
from
December 31, 2024 11:11
f593f60
to
5971959
Compare
Gedochao
changed the title
Improve handling for parallel Scala CLI runs
[WIP] Improve handling for parallel Scala CLI runs
Dec 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2034
Related Bloop issues:
FileAlreadyExistsException
on several parallel builds of the same project with Scala CLI scalacenter/bloop#2549???
unimplemented cases when several processes try to create Bloop at once scalacenter/bloop#2550