Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and rename PsNee.ino to PicoNee.ino #1

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kalymos
Copy link

@kalymos kalymos commented Apr 30, 2023

I suggest changing the file name and removing the parts of the code that concern the Attiny Atmega architectures to make the code more readable

kalymos added 2 commits April 30, 2023 20:41
I suggest changing the file name and removing the parts of the code that concern the Attiny Atmega architectures to make the code more readable
It's just for reference to the first developer.
@VoxelTek
Copy link
Owner

VoxelTek commented May 1, 2023

Well, I feel like it might be better to instead make this part of the original code, so that one singular "sketch" can be used for the RP2040 boards, ATmega, and ATtiny.

Although, if you think an individual version should be better, I'd be fine with that too,

@kalymos
Copy link
Author

kalymos commented May 2, 2023

All right.
I still tested the compilation of your code, and it seems to me that one of the compilation problems comes from PINB PIND which is a specific internal register call, which are not portable as is.
(this call makes it possible to change the state of several pins in a single cycle, it worked better for poor attiny with their internal clock. )
If you look in older versions of the code, you'll find some that don't call those registers.

have fun

@VoxelTek
Copy link
Owner

VoxelTek commented May 2, 2023

I feel like it shouldn't be too hard to reimplement that with something like PIO maybe on the Pico, so yeah, I'll look into it.

@VoxelTek
Copy link
Owner

Hey, @kalymos,

I have a question about your PsNee code. Within your code, you have multiple instances of the line bitClear(GATEWFCKPORT, DATABIT);. In your code, GATEWFCKPORT is defined as PINB. However, according to the arduino documentation, PINB is a read-only register, and bitClear is a function used to set a certain bit in a variable to 0. The output of bitClear isn't being fed into anything, and if PINB is read-only, I'm not sure I understand what the line is doing.

Once again, I appreciate all your work, and thank you for taking the time to read this.

Kind regards,
@VoxelTek

@kalymos
Copy link
Author

kalymos commented Jun 23, 2023 via email

@VoxelTek
Copy link
Owner

@kalymos do you remember what the purpose of that line is, though?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants