-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update and rename PsNee.ino to PicoNee.ino #1
base: main
Are you sure you want to change the base?
Conversation
I suggest changing the file name and removing the parts of the code that concern the Attiny Atmega architectures to make the code more readable
It's just for reference to the first developer.
Well, I feel like it might be better to instead make this part of the original code, so that one singular "sketch" can be used for the RP2040 boards, ATmega, and ATtiny. Although, if you think an individual version should be better, I'd be fine with that too, |
All right. have fun |
I feel like it shouldn't be too hard to reimplement that with something like PIO maybe on the Pico, so yeah, I'll look into it. |
Hey, @kalymos, I have a question about your PsNee code. Within your code, you have multiple instances of the line Once again, I appreciate all your work, and thank you for taking the time to read this. Kind regards, |
If you are talking about line 186, I believe you are right that it is
logically an error.
This should be tested, but for now I'm dedicated to or reverse engineering
the PU-8 board schematic, and I don't want to stray too far ;)
Le mar. 20 juin 2023 à 04:55, VoxelTek ***@***.***> a écrit :
… Hey, @kalymos <https://github.com/kalymos>,
I have a question about your PsNee code. Within your code, you have
multiple instances of the line bitClear(GATEWFCKPORT, DATABIT);. In your
code, GATEWFCKPORT is defined as PINB. However, according to the arduino
documentation, PINB is a read-only register, and bitClear is a function
used to set a certain bit in a variable to 0. The output of bitClear
isn't being fed into anything, and if PINB is read-only, I'm not sure I
understand what the line is doing.
Once again, I appreciate all your work, and thank you for taking the time
to read this.
Kind regards,
@VoxelTek <https://github.com/VoxelTek>
—
Reply to this email directly, view it on GitHub
<#1 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABDOKBHIYKWOGOHOGHUWQZ3XMEGLRANCNFSM6AAAAAAXRC3YRM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@kalymos do you remember what the purpose of that line is, though? |
I suggest changing the file name and removing the parts of the code that concern the Attiny Atmega architectures to make the code more readable