Add data-testid as a type of selector #256
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marking up components with
data-testidis a pretty popular way of providing somewhat namespaced access to DOM for the purpose of testing. Other testing tools have support fordata-testidbut I'll admit it's somewhat arbitrary as a selector and I appreciate that we probably want to keepBy::{X, Y, Z}to a minimum. Feel free to reject PR on those grounds.Creating my own helpers outside of
thirtyfourdoes work mostly fine except when it comes to creating Component with macros. Typing out#[by(css = "[data-testid=\"confirmation-confirm\"]")]feels somewhat cumbersome. That's really the motivation for this PR.I've gone with referring to
data-testidasTestidin Rust code. (nb. lowercase i). This feels weird but reflects the commonly used casing when adding testids in markup.