Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it explicit that user agents can modify or omit hints #121

Merged
merged 6 commits into from
Jul 6, 2022
Merged

Make it explicit that user agents can modify or omit hints #121

merged 6 commits into from
Jul 6, 2022

Conversation

arichiv
Copy link
Collaborator

@arichiv arichiv commented Jul 1, 2022 •
edited by pr-preview bot
Loading

This is addressing feedback from WebKit/standards-positions#20 (comment):

  • Fix bug in Request processing algo
  • Clarify UAs need not support all client hints to adopt standard

closes #120

Preview | Diff

@arichiv arichiv requested a review from yoavweiss July 1, 2022 16:25
@arichiv arichiv self-assigned this Jul 1, 2022
miketaylr
miketaylr reviewed Jul 1, 2022
View reviewed changes
Copy link
Collaborator

@miketaylr miketaylr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: could we change the commit message to reflect what it's actually accomplishing? Having a link back to WebKit's comments in the extended description is fine.

Also, https://wicg.github.io/savedata/#privacy-considerations has some nice text that could be generalized here. Mind adding some more to this change?

yoavweiss
yoavweiss reviewed Jul 4, 2022
View reviewed changes
index.bs Show resolved Hide resolved
yoavweiss
yoavweiss reviewed Jul 6, 2022
View reviewed changes
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
yoavweiss
yoavweiss approved these changes Jul 6, 2022
View reviewed changes
Copy link
Collaborator

@yoavweiss yoavweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % modification to the PR's title, to indicate what it does (e.g. "Make it explicit that user agents can modify or omit hints")

@arichiv arichiv changed the title Fixes & Clarifications based on WebKit feedback Make it explicit that user agents can modify or omit hints Jul 6, 2022
@arichiv arichiv merged commit 6bd54dd into main Jul 6, 2022
github-actions bot added a commit that referenced this pull request Jul 6, 2022
@arichiv @github-actions
Make it explicit that user agents can modify or omit hints (#121)
af7caab 
SHA: 6bd54dd
Reason: push, by @arichiv

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@miketaylr miketaylr deleted the webkit branch July 6, 2022 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miketaylr miketaylr miketaylr left review comments

@yoavweiss yoavweiss yoavweiss approved these changes

Assignees

@arichiv arichiv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make it clear that UAs are not required to support every client hint ever
3 participants
@arichiv @miketaylr @yoavweiss