Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Critical-CH restart time in navigation params #153

Merged
merged 12 commits into from
Jun 7, 2023
Merged

Update Critical-CH restart time in navigation params #153

merged 12 commits into from
Jun 7, 2023

Conversation

arichiv
Copy link
Collaborator

@arichiv arichiv commented May 19, 2023

This is needed for w3c/navigation-timing#188.


Preview | Diff

@arichiv arichiv self-assigned this May 19, 2023
index.bs Outdated Show resolved Hide resolved
@arichiv arichiv requested a review from yoavweiss May 22, 2023 16:42
@arichiv
Copy link
Collaborator Author

arichiv commented Jun 1, 2023

@yoavweiss Have time to take a look?

index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Show resolved Hide resolved
@noamr
Copy link

noamr commented Jun 7, 2023

@yoavweiss I'm not a reviewer for this spec. Could you take a look?
IMO it's still quite handwavy and the new issue #154 is quite a big technical debt, leaving this spec in the explainer realm, but could use an extra pair of eyes.

Copy link
Collaborator

@yoavweiss yoavweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % nit on the issue wording

index.bs Outdated Show resolved Hide resolved
@arichiv arichiv merged commit 193d599 into main Jun 7, 2023
@arichiv arichiv deleted the timing branch June 7, 2023 13:29
github-actions bot added a commit that referenced this pull request Jun 7, 2023
SHA: 193d599
Reason: push, by arichiv

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants