-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update numpy requirement from <2,>=1.23.3 to >=1.23.3,<3 #168
Conversation
Updates the requirements on [numpy](https://github.com/numpy/numpy) to permit the latest version. - [Release notes](https://github.com/numpy/numpy/releases) - [Changelog](https://github.com/numpy/numpy/blob/main/doc/RELEASE_WALKTHROUGH.rst) - [Commits](numpy/numpy@v1.23.3...v2.1.0) --- updated-dependencies: - dependency-name: numpy dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
WalkthroughThe changes involve updating the version constraints for the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Application
participant Numpy
User->>Application: Request to install dependencies
Application->>Numpy: Check version compatibility
Numpy-->>Application: Return available versions < 3.0
Application-->>User: Install compatible numpy version
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- requirements.txt (1 hunks)
- setup.py (1 hunks)
Additional comments not posted (2)
requirements.txt (1)
1-1
: LGTM! But verify compatibility with the newer versions ofnumpy
.The version constraint update for the
numpy
package is approved. However, it is important to ensure that the project's code and other dependencies are compatible with the newer versions ofnumpy
(2.x and 3.x) before merging this change.Please run the following script to verify compatibility:
If any of the tests fail or produce unexpected results, please investigate further and make necessary changes to ensure compatibility before merging this PR.
setup.py (1)
35-35
: LGTM!The code change is approved for the following reasons:
- Updating the
numpy
version constraint to<3
allows the project to utilize the latest features and improvements from NumPy 2.x releases while ensuring compatibility with existing code.- The minimum version requirement of
1.23.3
is still maintained, which is important for backward compatibility.- The change is localized to the
setup.py
file and does not require any modifications in other files.- The change is consistent with the PR objectives and the AI-generated summary.
Updates the requirements on numpy to permit the latest version.
Release notes
Sourced from numpy's releases.
... (truncated)
Commits
2f7fe64
Merge pull request #27236 from charris/prepare-2.1.0b6f434f
REL: Prepare for the NumPy 2.1.0 release [wheel build]3cf9394
Merge pull request #27234 from charris/backport-259847443dcc
Merge pull request #27233 from charris/backport-2722385b1cab
BUG: Allow fitting of degree zero polynomials with Polynomial.fit395a81d
DOC: reword discussion about shared arrays to hopefully be clearer5af2e96
Move NUMUSERTYPES thread safety discussion to legacy DType API docsd902c24
DOC: add docs on thread safety in NumPyc080180
Merge pull request #27229 from charris/backport-2722644ce7e8
BUG: FixPyArray_ZeroContiguousBuffer
(resize) with struct dtypesDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)Summary by CodeRabbit
numpy
package, allowing for versions up to but not including 3.0, which may enable access to newer features and improvements.requirements.txt
andsetup.py
to reflect the broader range of acceptablenumpy
versions.