Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update numpy requirement from <2,>=1.23.3 to >=1.23.3,<3 #168

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 1, 2024

Updates the requirements on numpy to permit the latest version.

Release notes

Sourced from numpy's releases.

2.1.0 (Aug 18, 2024)

NumPy 2.1.0 Release Notes

NumPy 2.1.0 provides support for the upcoming Python 3.13 release and drops support for Python 3.9. In addition to the usual bug fixes and updated Python support, it helps get us back into our usual release cycle after the extended development of 2.0. The highlights for this release are:

  • Support for the array-api 2023.12 standard.
  • Support for Python 3.13.
  • Preliminary support for free threaded Python 3.13.

Python versions 3.10-3.13 are supported in this release.

New functions

New function numpy.unstack

A new function np.unstack(array, axis=...) was added, which splits an array into a tuple of arrays along an axis. It serves as the inverse of [numpy.stack]{.title-ref}.

(gh-26579)

Deprecations

  • The fix_imports keyword argument in numpy.save is deprecated. Since NumPy 1.17, numpy.save uses a pickle protocol that no longer supports Python 2, and ignored fix_imports keyword. This keyword is kept only for backward compatibility. It is now deprecated.

    (gh-26452)

  • Passing non-integer inputs as the first argument of [bincount]{.title-ref} is now deprecated, because such inputs are silently cast to integers with no warning about loss of precision.

    (gh-27076)

Expired deprecations

  • Scalars and 0D arrays are disallowed for numpy.nonzero and numpy.ndarray.nonzero.

    (gh-26268)

  • set_string_function internal function was removed and PyArray_SetStringFunction was stubbed out.

... (truncated)

Commits
  • 2f7fe64 Merge pull request #27236 from charris/prepare-2.1.0
  • b6f434f REL: Prepare for the NumPy 2.1.0 release [wheel build]
  • 3cf9394 Merge pull request #27234 from charris/backport-25984
  • 7443dcc Merge pull request #27233 from charris/backport-27223
  • 85b1cab BUG: Allow fitting of degree zero polynomials with Polynomial.fit
  • 395a81d DOC: reword discussion about shared arrays to hopefully be clearer
  • 5af2e96 Move NUMUSERTYPES thread safety discussion to legacy DType API docs
  • d902c24 DOC: add docs on thread safety in NumPy
  • c080180 Merge pull request #27229 from charris/backport-27226
  • 44ce7e8 BUG: Fix PyArray_ZeroContiguousBuffer (resize) with struct dtypes
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Summary by CodeRabbit

  • New Features
    • Expanded compatibility for the numpy package, allowing for versions up to but not including 3.0, which may enable access to newer features and improvements.
  • Chores
    • Updated version constraints in both requirements.txt and setup.py to reflect the broader range of acceptable numpy versions.

Updates the requirements on [numpy](https://github.com/numpy/numpy) to permit the latest version.
- [Release notes](https://github.com/numpy/numpy/releases)
- [Changelog](https://github.com/numpy/numpy/blob/main/doc/RELEASE_WALKTHROUGH.rst)
- [Commits](numpy/numpy@v1.23.3...v2.1.0)

---
updated-dependencies:
- dependency-name: numpy
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file python Pull requests that update Python code labels Sep 1, 2024
Copy link

coderabbitai bot commented Sep 1, 2024

Walkthrough

The changes involve updating the version constraints for the numpy package in both the requirements.txt and setup.py files. The upper limit for numpy has been modified from <2 to <3, allowing compatibility with versions less than 3.0 while maintaining a minimum version of 1.23.3. This adjustment broadens the range of acceptable numpy versions across the project's dependencies.

Changes

Files Change Summary
requirements.txt, setup.py Updated numpy version constraint from <2 to <3, allowing compatibility with newer versions.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Application
    participant Numpy

    User->>Application: Request to install dependencies
    Application->>Numpy: Check version compatibility
    Numpy-->>Application: Return available versions < 3.0
    Application-->>User: Install compatible numpy version
Loading

🐰 "Oh, what a joy, a leap and a bound,
Numpy's new heights, we joyfully found!
With versions now open, we dance in delight,
Hop, skip, and jump, through day and through night!
A patch for our code, so clever and bright,
Let's celebrate changes, all fluffy and light!" 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between caa28af and cf65bd3.

Files selected for processing (2)
  • requirements.txt (1 hunks)
  • setup.py (1 hunks)
Additional comments not posted (2)
requirements.txt (1)

1-1: LGTM! But verify compatibility with the newer versions of numpy.

The version constraint update for the numpy package is approved. However, it is important to ensure that the project's code and other dependencies are compatible with the newer versions of numpy (2.x and 3.x) before merging this change.

Please run the following script to verify compatibility:

If any of the tests fail or produce unexpected results, please investigate further and make necessary changes to ensure compatibility before merging this PR.

setup.py (1)

35-35: LGTM!

The code change is approved for the following reasons:

  • Updating the numpy version constraint to <3 allows the project to utilize the latest features and improvements from NumPy 2.x releases while ensuring compatibility with existing code.
  • The minimum version requirement of 1.23.3 is still maintained, which is important for backward compatibility.
  • The change is localized to the setup.py file and does not require any modifications in other files.
  • The change is consistent with the PR objectives and the AI-generated summary.

@github-actions github-actions bot mentioned this pull request Sep 10, 2024
@AntObi AntObi merged commit b242843 into main Sep 18, 2024
13 checks passed
@dependabot dependabot bot deleted the dependabot/pip/numpy-gte-1.23.3-and-lt-3 branch September 18, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant