Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝 Add softmax and selectivity #193

Closed
wants to merge 3 commits into from
Closed

📝 Add softmax and selectivity #193

wants to merge 3 commits into from

Conversation

JiwooChloeLee
Copy link
Contributor

Pull Request Template

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)
Added softmax function and Selectivity in doper.py

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • Python version:
  • Operating System:

Reviewers

@mention individuals who you specifically want to involve in the discussion for this pull request and mention why they are needed in the discussion/why they are needed to review the pull request.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@AntObi AntObi self-requested a review December 11, 2023 11:43
Copy link

codecov bot commented Dec 12, 2023

Codecov Report

Attention: 24 lines in your changes are missing coverage. Please review.

Comparison is base (01cb34e) 72.71% compared to head (1630d6d) 73.04%.
Report is 53 commits behind head on chloeLeeDOper.

Files Patch % Lines
smact/dopant_prediction/doper.py 79.48% 16 Missing ⚠️
smact/data_loader.py 68.75% 5 Missing ⚠️
smact/__init__.py 80.00% 3 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##           chloeLeeDOper     #193      +/-   ##
=================================================
+ Coverage          72.71%   73.04%   +0.32%     
=================================================
  Files                 24       24              
  Lines               1913     1966      +53     
=================================================
+ Hits                1391     1436      +45     
- Misses               522      530       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AntObi
Copy link
Collaborator

AntObi commented Dec 12, 2023

HI @JiwooChloeLee, I've fixed the issue with the docs not building and some of the tests failing by merging the latest commits in SMACT into your fork. You'll have to update your own local installation to make sure it has all the changes that I've done.

Before I can merge this I need:

  • An updated test_doper.py file to test the apply_softmax argument
  • An updated example notebook demonstrating the use of apply_softmax and get_selectivity arguments
  • Fill out the PR template

Copy link
Collaborator

@AntObi AntObi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments for requested changes

) -> dict:
"""
Args:
num_dopants (int): The number of suggestions to return for n- and p-type dopants.
apply_softmax (bool): Whether to apply softmax to probabilities. (default = True)
get_selectivity (bool): Whether
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doc string incomplete for the get_selectivity argument


def get_dopants(
self,
num_dopants: int = 5,
self, num_dopants: int = 5, apply_softmax=False, get_selectivity=True
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test needs to be written for when apply_softmax is set to True

@JiwooChloeLee JiwooChloeLee deleted the branch WMD-group:chloeLeeDOper January 1, 2024 13:25
@JiwooChloeLee JiwooChloeLee deleted the chloeLeeDOper branch January 1, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants