Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subbranch #59

Closed
wants to merge 10 commits into from
Closed

Conversation

AtulRaghuvanshi73
Copy link

#31 Writing Documentation on Inserting and Removing DOM nodes.

I have written about some basic DOM manipluation methods

Copy link
Member

@rniwa rniwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this is not the documentation we want. We want to describe how node insertions & removals are implemented in WebKit, not how to use them in JS.

@AtulRaghuvanshi73
Copy link
Author

ok, I work on this and edit the PR

@AtulRaghuvanshi73
Copy link
Author

@rniwa can you suggest some resources to get some more info about how insertion and removal of dom nodes is done in webkit

@rniwa
Copy link
Member

rniwa commented Aug 14, 2023

@rniwa can you suggest some resources to get some more info about how insertion and removal of dom nodes is done in webkit

There is no documentation or resources to speak of. This is why it's a to-do item. I need to find a time to write them down.

@AtulRaghuvanshi73
Copy link
Author

I have made a couple of changes. If this is not how it should be done, it would be helpful someone gives some resources about how this should look it or what are the contents which are missing.

Copy link
Member

@rniwa rniwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

None of this content belongs to DOM section of the documentation. We need explanation of how things are implemented, not how JS API works. That belongs to MDN and such.

@AtulRaghuvanshi73
Copy link
Author

AtulRaghuvanshi73 commented Aug 14, 2023

Ok I'll work on this. For now I'll just close the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants