[AWS] Add image digest parameters #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
This allows setting the exact image hash to use. This is useful when using mutable tags like "latest" (used in our long running tests).
jsravn
force-pushed
the
add-image-digests
branch
from
cdfbcf7 to
887db57
Compare
nemani
reviewed
Mar 15, 2023
| @@ -844,7 +858,7 @@ Resources: | |||
| !If [IsAWSLogDriver, "coreapp", !Ref "AWS::NoValue"] | |||
| - Name: wa-web | |||
| Image: | |||
| !Join ["", [!Ref WAEntContRegistry, "/web:", !Ref WAEntContTag]] | |||
| !Join ["", [!Ref WAEntContRegistry, "/web:", !Ref WAEntContTag, !Ref WAEntWebImageDigest]] | |||
There was a problem hiding this comment.
Docker image ref is <registry>/<name>:<tag>@<digest>
so this should be !Join ["", [!Ref WAEntContRegistry, "/web:", !Ref WAEntContTag, "@", !Ref WAEntWebImageDigest]]
And so on for other changes.
But i see that this is an optional argument so maybe we should have a comment which says that digest should always be in the form of @sha:.... so that people using this wont get confused.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows setting the exact image hash to use. This is useful when using mutable tags like "latest" (used in our long running tests).