-
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SSO with OIDC #156
base: master
Are you sure you want to change the base?
SSO with OIDC #156
Conversation
Perhaps also solves #26? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert this change.
Other than that, I have oidc working with this fork using Authentik 2024.10.4 as the OIDC provider.
@@ -165,10 +168,10 @@ Hi, I'm Wingy. I made this app. My website is [samwing.dev](https://samwing.dev) | |||
<table> | |||
<tr> | |||
<td align="center"> | |||
<a href="https://github.com/Wingysam"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies. First time submitting a comment on a PR on mobile. These are the lines specifically to revert before merging. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It’s OK, I was worried about this previously but it resolves itself when @Wingysam merges.
Is there an image available with these changes? I tried building one, but encountered some weird extension issues when starting a container. |
I'd like to keep backwards compatibility with the Google configuration. I'm also concerned that calling it OIDC on the button labels might confuse people. I doubt that anyone in my family except for me has ever heard of OIDC. Maybe we could have an environment variable where the user provides the name/icon of the service being used for login? |
This change makes the single sign on capability generic and looks to satisfy the requirements of #131.
It's basically the same as what we have already for Google accounts but would support any OIDC provider. I have tested this configuration with OIDC to Google and with Authentik,
I have renamed the configuration options and environment variables to be
OIDC
instead of google. The required environment variables to be set now are:If you are using Google, for example, all of the above items apart from issuer (which is always
https://accounts.google.com
) are given to your when you download the JSON file that has the client ID and secret. For example:With something like Authentic, you get shown the URLs when you configure your OIDC provider:
When you are configuring an OIDC provider you must configure the following redirect URLs: