Fix hard coded CSS for User names in main Wishlists page. #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deanosim
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CSS for the color of Users names in the Wishlist page is hard coded into the a html element, by moving it from https://github.com/Wingysam/Christmas-Community/blob/master/src/views/wishlists.pug to https://github.com/Wingysam/Christmas-Community/blob/master/src/static/css/main.css it allows users to over ride and customize the css for the names.
It also allows users to change the text color to something that is readable when using dark bulma themes.
You can see in a dark theme the Names are very hard to read without changing them with custom.css
As you can see in the below screenshot the inline css has higher priority than all other css options so it needs to be moved to main.css