Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose strategy types #57

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Expose strategy types #57

wants to merge 7 commits into from

Conversation

AlfredoGJ
Copy link

What does this PR do?

Exposes Strategy Type and affirmative, unanimous strategies to be used in the Express and React packages

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have added necessary documentation (if appropriate)
  • I did review existing Pull Requests before submitting mine
  • I have added tests that prove my fix is effective or that my feature works

dependabot bot and others added 7 commits October 26, 2021 14:53
@dependabot
chore(deps): bump tmpl from 1.0.4 to 1.0.5
8714e79 
Bumps [tmpl](https://github.com/daaku/nodejs-tmpl) from 1.0.4 to 1.0.5.
- [Release notes](https://github.com/daaku/nodejs-tmpl/releases)
- [Commits](https://github.com/daaku/nodejs-tmpl/commits/v1.0.5)

---
updated-dependencies:
- dependency-name: tmpl
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot
chore(deps): bump y18n from 4.0.0 to 4.0.1
0d8959d 
Bumps [y18n](https://github.com/yargs/y18n) from 4.0.0 to 4.0.1.
- [Release notes](https://github.com/yargs/y18n/releases)
- [Changelog](https://github.com/yargs/y18n/blob/master/CHANGELOG.md)
- [Commits](https://github.com/yargs/y18n/commits)

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot
chore(deps): bump ssri from 6.0.1 to 6.0.2
9234b7d 
Bumps [ssri](https://github.com/npm/ssri) from 6.0.1 to 6.0.2.
- [Release notes](https://github.com/npm/ssri/releases)
- [Changelog](https://github.com/npm/ssri/blob/v6.0.2/CHANGELOG.md)
- [Commits](npm/ssri@v6.0.1...v6.0.2)

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot
chore(deps): bump handlebars from 4.5.3 to 4.7.7
ac00027 
Bumps [handlebars](https://github.com/wycats/handlebars.js) from 4.5.3 to 4.7.7.
- [Release notes](https://github.com/wycats/handlebars.js/releases)
- [Changelog](https://github.com/handlebars-lang/handlebars.js/blob/master/release-notes.md)
- [Commits](handlebars-lang/handlebars.js@v4.5.3...v4.7.7)

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot
chore(deps): bump lodash from 4.17.19 to 4.17.21
886e82a 
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.19 to 4.17.21.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](lodash/lodash@4.17.19...4.17.21)

Signed-off-by: dependabot[bot] <[email protected]>
@AlfredoGJ
Merge branch 'wizeline:master' into master
a895b0e
add strategy types to index.ts
a3ebc68
LeoUrzua
LeoUrzua reviewed Nov 15, 2021
View reviewed changes
packages/access-decision-manager/src/index.ts
@@ -1,4 +1,7 @@
import AccessDecisionManager from './access-decision-manager';

export * from './voter';
export * from './strategy'
export * from './strategy/'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is duplicated!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One export is for the strategy.ts file, which contains the Strategy type, and the other for the strategy directory from where we export the unanimous and affirmative strategies

Copy link
Author

@AlfredoGJ AlfredoGJ Nov 19, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also I'm wondering what type of commit to use, im thinking of refactor but also feat, what do you think Leo?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd use chore:

@LeoUrzua
Copy link
Collaborator

Hey Alfredo, thanks a lot for creating this PR!
When you created your commits, didn't you get a message to follow some conventional commits https://www.conventionalcommits.org/en/v1.0.0/
it'd be nice to rebase your commits to follow that standard so, we can have the CHANGELOG file updated https://github.com/wizeline/access-decision-manager/blob/master/CHANGELOG.md

let me know if you have questions, I'd like to merge this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeoUrzua LeoUrzua LeoUrzua left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlfredoGJ @LeoUrzua