Don't prepare the response body for HEAD requests in WP_REST_Taxonomies_Controller #7925
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
| * @param string $method HTTP method. | ||
| * @return bool Whether the request is of the given method. | ||
| */ | ||
| public function is_method( $method ) { |
There was a problem hiding this comment.
| public function is_method( $method ) { | |
| public function is_method( $method ): bool { |
MInimum required PHP version allows the use of type hints, and for bool it is already in use at other places, so imho we should introduce this new function with a type hint.
There was a problem hiding this comment.
Thanks for the review.
There is currently no agreement on using return type declarations in WordPress Core, so I’d refrain from using them for now. I’m fine with using them as soon as the Community reaches a consensus.
There was a problem hiding this comment.
The HTML API for example uses it, so there are already some examples for return types in core. But I get your point, so waiting for a consensus is fine with me.
| $request = new WP_REST_Request( 'HEAD', '/wp/v2/taxonomies' ); | ||
| $hook_name = 'rest_prepare_taxonomy'; | ||
| $filter = new MockAction(); | ||
| $callback = array( $filter, 'filter' ); | ||
| add_filter( $hook_name, $callback ); | ||
| $response = rest_get_server()->dispatch( $request ); | ||
| remove_filter( $hook_name, $callback ); |
There was a problem hiding this comment.
NIT: I know this is "just a test", but my inner monk wants to sort this. so that this is better readable.
|
Closed in favour of #7970. |
Trac ticket: https://core.trac.wordpress.org/ticket/56481
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.