Show the strings of a translation event #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akirk
reviewed
Apr 10, 2024
psrpinto
reviewed
Apr 17, 2024
psrpinto
requested changes
Apr 17, 2024
There was a problem hiding this comment.
I'm getting a 404 when trying to access the translations page, by clicking in an entry in the stats table. The URL is:
http://localhost:8888/events/test-hosts/pt/
Not sure why it's 404ing.
psrpinto
reviewed
Apr 17, 2024
|
@psrpinto could you try again with the latest regex updates? |
|
The 404 is still there but I now realised why it's happening: it lacks the |
amieiro
commented
Apr 19, 2024
amieiro
commented
Apr 19, 2024
amieiro
commented
Apr 19, 2024
Co-authored-by: Alex Kirk <[email protected]>
Co-authored-by: Paulo Pinto <[email protected]>
Co-authored-by: Paulo Pinto <[email protected]>
Co-authored-by: Paulo Pinto <[email protected]>
Co-authored-by: Jesús Amieiro Becerra <[email protected]>
psrpinto
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #169. Needs GlotPress/gp-translation-helpers#222.
This adds links to the Translations table:
For example for the WordCamp Asia contributor day, this now adds new URLs like:
and that page then lists all the strings that were modified in the project:
Here you can see how this also takes into account individual project permissions. I am a PTE for German in the Friends plugin, but not a GTE for German, thus cannot approve in Core: