Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new capabilty to make a form field editable #269

Merged
merged 23 commits into from
May 24, 2024
Merged

Conversation

trymebytes
Copy link
Collaborator

@trymebytes trymebytes commented May 10, 2024

Fixes #227

To test, kindly create the events that satisfies the conditions listed in the issue #227

  1. Create an event that starts in the future, you would only be able to edit the following;
    Title
    Description
    Dates

A. Edit the event created in 1 to start now

  1. With no contributions to the event created in A, you would only be able to edit the following;
    Title
    Description
    Dates

  2. Add contributions to the event created in A, you would only be able to edit the following;
    Title
    Description
    Extend the end date

B. Find or create an event that has ended

  1. Within 0-1 hour after the event has ended, you would only be able to edit the following;
    Title
    Description
    Extend the end date

  2. After one hour after the event has ended, you would only be able to edit the following;
    Description

@trymebytes trymebytes self-assigned this May 10, 2024
@trymebytes trymebytes marked this pull request as ready for review May 17, 2024 13:40
@trymebytes trymebytes requested review from akirk, psrpinto and amieiro May 17, 2024 13:40
Copy link
Member

@psrpinto psrpinto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Got a few comments

includes/event/event-capabilities.php Outdated Show resolved Hide resolved
includes/event/event-capabilities.php Outdated Show resolved Hide resolved
includes/event/event-capabilities.php Outdated Show resolved Hide resolved
includes/event/event-capabilities.php Show resolved Hide resolved
includes/event/event-capabilities.php Show resolved Hide resolved
@trymebytes
Copy link
Collaborator Author

Thank you for catching these, I'll address them.

@trymebytes trymebytes requested a review from psrpinto May 21, 2024 17:28
templates/events-form.php Outdated Show resolved Hide resolved
Copy link
Member

@psrpinto psrpinto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good 👍

However, there's an issue when trying to update an event that is active now and has stats (step A.3 in the testing instructions), I get:

Error: Invalid time zone.

@trymebytes
Copy link
Collaborator Author

Thanks for testing, taking another look.

@trymebytes trymebytes requested review from psrpinto and akirk May 23, 2024 14:16
@trymebytes trymebytes merged commit 22139dd into trunk May 24, 2024
3 checks passed
@trymebytes trymebytes deleted the edit-form-fields branch May 24, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make it possible to edit certain fields of a past event
3 participants