-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new capabilty to make a form field editable #269
Conversation
88b8dce
to
044d1f4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Got a few comments
Thank you for catching these, I'll address them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good 👍
However, there's an issue when trying to update an event that is active now and has stats (step A.3 in the testing instructions), I get:
Error: Invalid time zone.
Thanks for testing, taking another look. |
cab5f1c
to
2cd5b45
Compare
Fixes #227
To test, kindly create the events that satisfies the conditions listed in the issue #227
Title
Description
Dates
A. Edit the event created in 1 to start now
With no contributions to the event created in A, you would only be able to edit the following;
Title
Description
Dates
Add contributions to the event created in A, you would only be able to edit the following;
Title
Description
Extend the end date
B. Find or create an event that has ended
Within 0-1 hour after the event has ended, you would only be able to edit the following;
Title
Description
Extend the end date
After one hour after the event has ended, you would only be able to edit the following;
Description