Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update json_serializable to get to analyzer 5 #103

Merged
merged 4 commits into from
Sep 27, 2023
Merged

Conversation

robbecker-wf
Copy link
Member

@robbecker-wf robbecker-wf commented Sep 27, 2023

Motivation

We want to get to analyzer 5 and prepare for Dart 3.

Changes

Update json_serializable to 6 and rebuild. Fix CI matrix to run on only supported Dart versions.

Release Notes

Review

See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.

Please review:

QA Checklist

  • Tests were updated and provide good coverage of the changeset and other affected code
  • Manual testing was performed if needed

Merge Checklist

While we perform many automated checks before auto-merging, some manual checks are needed:

  • A Frontend Frameworks Architecture member has reviewed these changes
  • There are no unaddressed comments - this check can be automated if reviewers use the "Request Changes" feature
  • For release PRs - Version metadata in Rosie comment is correct

@robbecker-wf robbecker-wf changed the title Update json_serializable Update json_serializable to get to analyzer 5 Sep 27, 2023
@aviary2-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@robbecker-wf robbecker-wf marked this pull request as ready for review September 27, 2023 20:33
@robbecker-wf
Copy link
Member Author

+10 @Workiva/release-management-p

Copy link
Contributor

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@rmconsole6-wk rmconsole6-wk merged commit 14dc466 into master Sep 27, 2023
4 checks passed
@rmconsole6-wk rmconsole6-wk deleted the analyzer_5 branch September 27, 2023 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants