Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEDX-687 : GHA OSS changes to dependency_validator #110

Merged
merged 3 commits into from
Apr 5, 2024
Merged

Conversation

alishadalal-wk
Copy link
Contributor

Summary

Finish migration to GHA.

  • Remove Dockerfile
  • Remove skynet.yaml
  • Generate an SBOM (see the guide)

Testing

  • CI passing
  • cyclone DX file attached as an artifact on the GHA build

@aviary-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@robbecker-wf
Copy link
Member

we can probably remove Dart 2.18 from the test matrix leaving just 2.19.6

@robbecker-wf
Copy link
Member

QA+1 CI passes, cyclone file attached, required GHA set

@robbecker-wf robbecker-wf marked this pull request as ready for review April 5, 2024 17:46
@robbecker-wf
Copy link
Member

@Workiva/release-management-p

Copy link
Contributor

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@rmconsole4-wk rmconsole4-wk merged commit 2dfcf38 into master Apr 5, 2024
3 checks passed
@rmconsole4-wk rmconsole4-wk deleted the FEDX-687 branch April 5, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants