Support Pub Workspaces #138
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #137 by supporting use in a mono-repo
Changes
In a regular package: nothing
In a sub-package of a workspace: nothing
In a workspace: instead of failing, recursively run itself on all sub-packages
I did remove the error condition that
dart pub getmust be run before running the tool, since that was throwing errors for workspaces, and I did not see a use for it (thepubspec.lockor.dart_toolfiles are never checked, only the code andpubspec.yaml).Testing/QA Instructions
Looking into adding unit tests now, but basically, create a workspace and try running the tool in there.
For now, I had to add a dependency override on pubspec_parse until dart-lang/tools#1948 is merged. For some reason that's affecting the tests, so many of them are failing as they can't override the package while executing.
@evanweible-wf for review