Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consume null-safe over_react v5 and over_react_test v3 #246

Merged

Conversation

sourcegraph-wk
Copy link

This PR sets the lower bound of over_react to ^5.0.0 and over_react_test to ^3.0.0 so that all repos at Workiva
are consuming the null-safe versions of these packages.

These major versions are a critical step towards unlocking null safety in Workiva's Dart ecosystem -
and have already been tested and verified as safe for consumption using the
w_module test PR listed in this SourceGraph batch.

Due to the exhaustive consumption testing already performed in this repository by the FED team prior to
releasing over_react 5.0.0, these changes can be merged without approval from a FED team member.

For more information about these changes, see this post in the #frontend-advocate-network channel.
Otherwise, reach out to the FED team in #support-ui-platform with any specific questions or concerns.

Created by Sourcegraph batch change Workiva/over_react-5.0_raise-lower.

@aviary2-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

Copy link
Contributor

@aaronlademann-wf aaronlademann-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 / QA +1

  • Passing CI

@Workiva/release-management-pp

Copy link
Contributor

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@rmconsole2-wf rmconsole2-wf merged commit 6bffdd8 into master Mar 29, 2024
8 checks passed
@rmconsole2-wf rmconsole2-wf deleted the batch/fed/over_react_5/p2_raise_lower/w_module branch March 29, 2024 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants