Draw call batching for Paths #81
Conversation
.../src/commonMain/kotlin/earth/worldwind/shape/milstd2525/AbstractMilStd2525TacticalGraphic.kt
Outdated
Show resolved
Hide resolved
.../src/commonMain/kotlin/earth/worldwind/shape/milstd2525/AbstractMilStd2525TacticalGraphic.kt
Outdated
Show resolved
Hide resolved
worldwind/src/commonMain/kotlin/earth/worldwind/layer/RenderableLayer.kt
Outdated
Show resolved
Hide resolved
worldwind/src/commonMain/kotlin/earth/worldwind/layer/RenderableLayer.kt
Outdated
Show resolved
Hide resolved
worldwind/src/commonMain/kotlin/earth/worldwind/layer/RenderableLayer.kt
Outdated
Show resolved
Hide resolved
worldwind/src/commonMain/kotlin/earth/worldwind/layer/RenderableLayer.kt
Outdated
Show resolved
Hide resolved
worldwind/src/commonMain/kotlin/earth/worldwind/render/VertexState.kt
Outdated
Show resolved
Hide resolved
| @@ -9,31 +9,46 @@ import earth.worldwind.util.kgl.KglUniformLocation | |||
| open class TriangleShaderProgram : AbstractShaderProgram() { | |||
| override var programSources = arrayOf( | |||
| """ | |||
| #version 300 es | |||
There was a problem hiding this comment.
Should we add ES 3.0 declaration in Android manifest also? Or we already have it there?
There was a problem hiding this comment.
just use it for this file. We will need to rewrite all other shaders if this will be added to manifest, probably should be done in separate pr if ever
| @@ -44,14 +45,36 @@ abstract class AbstractShape(override var attributes: ShapeAttributes): Abstract | |||
| override var highlightAttributes: ShapeAttributes? = null | |||
| override var isHighlighted = false | |||
| var maximumIntermediatePoints = 10 | |||
| protected lateinit var activeAttributes: ShapeAttributes | |||
| protected var isSurfaceShape = false | |||
| lateinit var activeAttributes: ShapeAttributes | |||
There was a problem hiding this comment.
Do we still need to have it public?
There was a problem hiding this comment.
Yes, still used in PathSet to get attributes
| protected var isSurfaceShape = false | ||
| lateinit var activeAttributes: ShapeAttributes | ||
| protected set | ||
| var isSurfaceShape = false |
There was a problem hiding this comment.
Smae here. Do we still need to hava it public?
There was a problem hiding this comment.
Yes, still used in PathSet to get attributes
| var lastRequestedFrameIndex = 0L | ||
|
|
||
| open fun addToBatch(rc : RenderContext) : Boolean { | ||
| return rc.currentLayer is RenderableLayer && allowBatching && !isHighlighted |
There was a problem hiding this comment.
In case of Graticule it will not b a renderable layer. Can we remove this cast check?
There was a problem hiding this comment.
Added TODO comment, better to address that in another PR with more testing
ComBatVision
force-pushed
the
develop
branch
5 times, most recently
from
5811728 to
cfa9e03
Compare
IOTRFAFH
force-pushed
the
lines_batching_attempt
branch
2 times, most recently
from
3c78897 to
dde82c9
Compare
IOTRFAFH
force-pushed
the
lines_batching_attempt
branch
from
dde82c9 to
f2e153a
Compare
ComBatVision
force-pushed
the
develop
branch
2 times, most recently
from
4bfbf07 to
eeaba99
Compare
No description provided.