Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adjust the popup direction of combobox to adaptive #10

Merged
merged 1 commit into from
Nov 29, 2024
Merged

fix: adjust the popup direction of combobox to adaptive #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions desktop/ui/GetStartedView.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,26 @@ Item {

model: daemon.availableAddresses
width: 360

popup.y: {
// Get the absolute coordinates of the combo box in the window
var absoluteY = addressCombo.mapToGlobal(0, 0).y;
// Get window height
var windowHeight = Window.window ? Window.window.height : Screen.height;
// Calculate the available space below
var spaceBelow = windowHeight - (absoluteY + height);
// Calculate the available space above
var spaceAbove = absoluteY;
// Default height of popup
var popupHeight = popup.height;

// If there is not enough space below and enough space above, pop it up
if (spaceBelow < popupHeight && spaceAbove >= popupHeight) {
return -popupHeight;
}
// By default, it will pop up downwards
return height;
}
}

TextField {
Expand Down