Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add gasPrice implementation for sui and solana #109

Merged
merged 6 commits into from
Oct 17, 2023
Merged

Add gasPrice implementation for sui and solana #109

merged 6 commits into from
Oct 17, 2023

Conversation

abhidtu2014
Copy link
Contributor

@abhidtu2014 abhidtu2014 commented Oct 12, 2023 •
edited
Loading

@abhidtu2014 abhidtu2014 requested a review from a team October 12, 2023 12:14
@abhidtu2014 abhidtu2014 force-pushed the feat/add-gas-price-for-solana-and-sui branch from 6192261 to ec445f8 Compare October 12, 2023 12:19
mat1asm
mat1asm reviewed Oct 12, 2023
View reviewed changes
src/utils.ts Show resolved Hide resolved
mat1asm
mat1asm reviewed Oct 12, 2023
View reviewed changes
src/wallets/base-wallet.ts Outdated Show resolved Hide resolved
solanoepalacio
solanoepalacio approved these changes Oct 16, 2023
View reviewed changes
Copy link
Collaborator

@solanoepalacio solanoepalacio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll approve so that you can merge, but please make the change to throw an error instead of returning 0n in case we don't find a gas-price for some chain, otherwise it will generate silent failures that will be hard to debug

@abhidtu2014 abhidtu2014 merged commit 44a7255 into main Oct 17, 2023
1 check passed
@abhidtu2014 abhidtu2014 deleted the feat/add-gas-price-for-solana-and-sui branch October 17, 2023 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mat1asm mat1asm mat1asm approved these changes

@solanoepalacio solanoepalacio solanoepalacio approved these changes

@scnale scnale Awaiting requested review from scnale

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@abhidtu2014 @solanoepalacio @scnale @mat1asm