Moving to a TS-first gRPC compilation solution #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Same functionality, less hassle. I am now a much better and happier man because of these changes. |
iturricf
approved these changes
May 17, 2023
| rpc AcquireLock (AcquireLockRequest) returns (AcquireLockResponse); | ||
| rpc ReleaseLock (ReleaseLockRequest) returns (google.protobuf.Empty); | ||
| } | ||
|
|
||
| message AcquireLockRequest { | ||
| string chain_name = 1; | ||
| optional string address = 2; | ||
| // FIXME: We are missing waitToAcquireTimeout. |
There was a problem hiding this comment.
why are we missing waitToAcquireTimeout? is it bc it's not supported or bc it's not implemented here?
There was a problem hiding this comment.
Yes that would be something that is addressed within Issue #55
src/grpc/client.ts
Outdated
| @@ -19,7 +20,9 @@ export class ClientWalletManager implements IClientWalletManager { | |||
| this.logger = createLogger(options?.logger, options?.logLevel, { label: 'WalletManager' }); | |||
| this.managers = {} as Record<ChainName, ChainWalletManager>; | |||
|
|
|||
| this.grpcClient = new WalletManagerProtocol(`${host}:${port}`, grpc.credentials.createInsecure()) | |||
| // this.walletManagerGRPCClient = new WalletManagerProtocol(`${host}:${port}`, grpc.credentials.createInsecure()) | |||
There was a problem hiding this comment.
can we get rid of this if it's not used?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.