Merge pull request #349 from MJMortimer/f-init-params

Initialise Parameters property in XeroHttpClient constructor
XeroAPI · Sep 11, 2018 · e01e013 · e01e013
2 parents 95346f3 + 8481e9a
commit e01e013
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 2 deletions.
diff --git a/CoreTests/ApiWrapperTest.cs b/CoreTests/ApiWrapperTest.cs
@@ -6,6 +6,11 @@ namespace CoreTests
 {
     public class ApiWrapperTest
     {
+        public ApiWrapperTest()
+        {
+            System.Net.ServicePointManager.SecurityProtocol = System.Net.SecurityProtocolType.Tls12;
+        }
+
         private IXeroCoreApi _api;
 
         protected Account BankAccount { get; set; }

diff --git a/CoreTests/App.config b/CoreTests/App.config
@@ -1,7 +1,7 @@
 <?xml version="1.0" encoding="utf-8"?>
 <configuration>
   <startup>
-    <supportedRuntime version="v4.0" sku=".NETFramework,Version=v4.0"/>
+    <supportedRuntime version="v4.0" sku=".NETFramework,Version=v4.5.1"/>
   </startup>
 
   <appSettings>

diff --git a/CoreTests/CoreTests.csproj b/CoreTests/CoreTests.csproj
@@ -9,7 +9,7 @@
     <AppDesignerFolder>Properties</AppDesignerFolder>
     <RootNamespace>CoreTests</RootNamespace>
     <AssemblyName>CoreTests</AssemblyName>
-    <TargetFrameworkVersion>v4.0</TargetFrameworkVersion>
+    <TargetFrameworkVersion>v4.5.1</TargetFrameworkVersion>
     <FileAlignment>512</FileAlignment>
     <SolutionDir Condition="$(SolutionDir) == '' Or $(SolutionDir) == '*Undefined*'">..\</SolutionDir>
     <TargetFrameworkProfile />
@@ -24,6 +24,7 @@
     <ErrorReport>prompt</ErrorReport>
     <WarningLevel>4</WarningLevel>
     <LangVersion>5</LangVersion>
+    <Prefer32Bit>false</Prefer32Bit>
   </PropertyGroup>
   <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Release|AnyCPU' ">
     <PlatformTarget>AnyCPU</PlatformTarget>
@@ -33,6 +34,7 @@
     <DefineConstants>TRACE</DefineConstants>
     <ErrorReport>prompt</ErrorReport>
     <WarningLevel>4</WarningLevel>
+    <Prefer32Bit>false</Prefer32Bit>
   </PropertyGroup>
   <PropertyGroup>
     <StartupObject />

diff --git a/Xero.Api/Infrastructure/Http/XeroHttpClient.cs b/Xero.Api/Infrastructure/Http/XeroHttpClient.cs
@@ -24,6 +24,7 @@ private XeroHttpClient(IJsonObjectMapper jsonMapper, IXmlObjectMapper xmlMapper)
         {
             JsonMapper = jsonMapper;
             XmlMapper = xmlMapper;
+            Parameters = new NameValueCollection();
         }
 
         public XeroHttpClient(string baseUri, IAuthenticator auth, IConsumer consumer, IUser user,