Improve build scripts and documentation #305
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create a worktree is a local repository is available. If not, skip a useless check-out in current cloning process.
fifield
reviewed
Sep 26, 2023
|
|
||
| # Use --llvm-worktree <directory-of-local-LLVM-repo> to reuse some existing | ||
| # local LLVM git repository | ||
| if [ x"$1" == x--llvm-worktree ]; then |
There was a problem hiding this comment.
Personally when I have an existing llvm repo I simply don't run this script (actually I never run this script...). I wonder if this just adds complexity for a personal git preference?
|
As a general comment it would be great if the documentation had more focus on how drive cmake and documenting the cmake options instead of being centered around a bunch of bespoke scripts. Example. That way people can catch their own fish. |
|
That is good feedback. Since these scripts were used in the CI I focused on evolving them but yes, we can avoid using them at all too when we are not in a clean slate situation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.